[codex] Add Claude Opus 4.8 support#16
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9945538f76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| low: "reasoning_low", | ||
| medium: "reasoning_medium", | ||
| high: "reasoning_high", | ||
| xhigh: "reasoning_xhigh", |
There was a problem hiding this comment.
Preserve xhigh effort for Opus 4.8
When users select model.reasoning=xhigh for this newly added Opus 4.8 profile, resolveAnthropicReasoning keeps applied as xhigh but the adaptive-thinking branch then calls toAnthropicOutputEffort, which converts xhigh to max. Anthropic documents xhigh and max as distinct accepted effort values for Claude Opus 4.8 (https://platform.claude.com/docs/en/build-with-claude/effort), so this makes Codelia's xhigh setting run at the more expensive/deeper max level rather than the requested intermediate level.
Useful? React with 👍 / 👎.
Summary
Validation