Skip to content

Improve handling of worker crash events #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertkluin merged 6 commits into from
Jun 10, 2025
Merged

Improve handling of worker crash events #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
636553f
Improve handling of worker crash events
robertkluin Jun 5, 2025
2dcdc6a
Increase default retry timeouts and improve retry logging
robertkluin Jun 5, 2025
0a351d9
Increase timeouts and set them within custom_workflow
robertkluin Jun 5, 2025
ba0d47c
Bump dependencies
robertkluin Jun 5, 2025
afcc289
Load Koreo Resources sequentially to avoid prepare trashing
robertkluin Jun 10, 2025
5bd43c8
Update dependencies
robertkluin Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
186 changes: 105 additions & 81 deletions pdm.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
[project]
name = "koreo-controller"
version = "0.1.16"
version = "0.1.17"
description = "Koreo Controller runs Koreo Core as a Kubernetes Controller."
authors = [
{name = "Eric Larssen", email = "eric.larssen@realkinetic.com"},
{name = "Robert Kluin", email = "robert.kluin@realkinetic.com"},
]
dependencies = [
"koreo-core==0.1.11",
"cel-python==0.2.0",
"kr8s==0.20.6",
"koreo-core==0.1.13",
"cel-python==0.3.0",
"kr8s==0.20.7",
"uvloop==0.21.0",
]
requires-python = "==3.13.*"
Expand All @@ -21,12 +21,12 @@ distribution = false

[dependency-groups]
test = [
"pytest==8.3.5",
"pytest-cov==6.0.0",
"pytest==8.4.0",
"pytest-cov==6.1.1",
]
tooling = [
"ruff==0.11.2",
"pyright==1.1.397",
"ruff==0.11.13",
"pyright==1.1.401",
]
all = ["koreo-core[test,tooling]"]

Expand Down
13 changes: 11 additions & 2 deletions src/controller/custom_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,12 @@ async def workflow_controller_system(
event_handler, request_queue = reconcile.get_event_handler(namespace=namespace)

event_config = events.Configuration(
event_handler=event_handler, namespace=namespace
event_handler=event_handler,
namespace=namespace,
max_unknown_errors=10,
retry_delay_base=30,
retry_delay_jitter=30,
retry_delay_max=900,
)

if not (
Expand Down Expand Up @@ -95,7 +100,11 @@ async def workflow_controller_system(
managed_resource_api.timeout = RECONNECT_TIMEOUT

scheduler_config = scheduler.Configuration(
work_processor=_configure_reconciler(api=managed_resource_api)
concurrency=2,
frequency_seconds=1200,
retry_delay_base=30,
retry_delay_max=900,
work_processor=_configure_reconciler(api=managed_resource_api),
)

async with asyncio.TaskGroup() as tg:
Expand Down
6 changes: 3 additions & 3 deletions src/controller/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ class Configuration(NamedTuple):

max_unknown_errors: int = 10

retry_delay_base: int = 10
retry_delay_jitter: int = 15
retry_delay_max: int = 300
retry_delay_base: int = 30
retry_delay_jitter: int = 30
retry_delay_max: int = 900


def _watch_key(api_version: str, kind: str):
Expand Down
Loading