fix: improve recommendation input validation for unsupported values (#676)#677
Open
mishtiagrawal02-cloud wants to merge 1 commit into
Open
Conversation
|
@mishtiagrawal02-cloud is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves recommendation input validation by adding stricter checks for unsupported values in recommendation inputs.
Previously, validation only checked for missing fields, which allowed unsupported values (such as invalid time availability, unsupported experience levels, or unsupported interests) to reach recommendation logic and potentially cause inconsistent behavior. This update validates allowed values and returns meaningful validation errors. Additional tests were added to cover invalid input cases.
Related Issue
Closes #676
Type of Change
data/projects.jsonWhat Was Changed
utils/recommender.pytests/test_basic.pyHow to Test This PR
Expected result:
Test Results
Self-Review Checklist
Notes for Reviewer
This PR improves recommendation input validation by rejecting unsupported values and adds test coverage for invalid input cases.