Fix import button bug and enhance security#665
Open
AnishkumarProjects05 wants to merge 1 commit into
Open
Conversation
|
@AnishkumarProjects05 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR Fixes the Import from Github Button which was non Functionable.Clicking the Button Import From GitHub will Navigate to an Dialog Box where the user can fetch the Respective Github Username and Fetch the Languages used from the Username's Repo and Autofill in this Text Box. Follows the Github Authentication Security Path by using OAuth Flow instead of Manually Checking Flow
Related Issue
The problem is that Flask was setting up your blueprint routes before the secret_key for the application was actually set, so the session signing system had a blank context. Also, your server was running from a subfolder, so load_dotenv() was looking in the wrong place for your .env config file, and failing to find it.
Closes #659
Type of Change
data/projects.jsonWhat Was Changed
OAuth GitHub Login Route
→ New feature to redirect users to authenticate with GitHub before accessing the repositories. GitHub Callback Route→ New feature to receive an authorisation code after successful login to GitHub.New feature to securely exchange authorisation code from GitHub for an access token.
Access Token Retrieval APISession Storage→ New feature to temporarily store the access token for GitHub account.User Repositories API” → New feature to get all the repositories the user has access to on GitHub.
Repository Import API→ Ability to import repositories from GitHub to application.redirect() Feature→ New feature to automatically redirect users from one page to another.Use of
requests Library→ Add new feature to interact with GitHub RESTful APIs usingrequestslibrary of python.utils/recommender.pyclear_cache()functiontests/test_basic.pyHow to Test This PR
git checkout features/devpathpip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results
Test Check :
Screenshots
Self-Review Checklist
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
None