Skip to content

data: add intermediate projects#157

Merged
komalharshita merged 3 commits into
komalharshita:mainfrom
iscompg:data/add-intermediate-projects
Jun 1, 2026
Merged

data: add intermediate projects#157
komalharshita merged 3 commits into
komalharshita:mainfrom
iscompg:data/add-intermediate-projects

Conversation

@iscompg
Copy link
Copy Markdown

@iscompg iscompg commented May 16, 2026

Summary [required]

Added two intermediate level projects for "data":

  1. movie recommendation system
  2. sentiment analysis web app

Also added starter_code scaffold files for both with basic idea in comments and roadmap

Related Issue [required]

add few more intermediate projects for better options (Issue #68)

Closes #68

Type of Change [required]

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
data/projects.json Added 2 new intermediate projects
starter_code/movie_recommender.py Added basic intro to the project (in comments)
starter_code/sentiment_app.py Added basic intro to the project (in comments)

How to Test This PR [required]

  1. Clone this branch: git checkout data/add-intermediate-projects
  2. Install dependencies: pip install -r requirements.txt
  3. Run the tests: python tests/test_basic.py

Expected test output:

27 passed, 0 failed out of 27 tests

Test Results [required]

  PASS  test_projects_json_loads
  PASS  test_each_project_has_required_fields
  PASS  test_find_project_by_id_found
  PASS  test_find_project_by_id_missing
  PASS  test_parse_skills_basic
  PASS  test_parse_skills_empty_string
  PASS  test_parse_skills_single_entry
  PASS  test_score_single_project_full_match
  PASS  test_score_single_project_no_match
  PASS  test_get_recommendations_returns_results
  PASS  test_get_recommendations_max_three
  PASS  test_get_recommendations_no_match_returns_empty
  PASS  test_get_recommendations_result_format
  PASS  test_validate_all_valid
  PASS  test_validate_missing_skills
  PASS  test_validate_missing_level
  PASS  test_validate_missing_interest
  PASS  test_validate_missing_time
  PASS  test_validate_all_missing
  PASS  test_home_route
  PASS  test_recommend_api_valid
  PASS  test_recommend_api_missing_field
  PASS  test_recommend_api_empty_body
  PASS  test_project_detail_found
  PASS  test_project_detail_not_found
  PASS  test_view_code_found
  PASS  test_download_code_found

27 passed, 0 failed out of 27 tests

Self-Review Checklist [required]

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all 27 tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

starter_code files currently contain introductory scaffolding and roadmap guidance. Detailed implementations can be expanded in future contributions.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2026

@iscompg is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

@komalharshita
Copy link
Copy Markdown
Owner

@iscompg resolve the merge conflicts

Copy link
Copy Markdown
Owner

@komalharshita komalharshita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Adding intermediate-level projects is a valuable improvement for DevPath, and the selected project ideas are relevant and educational.

However, after review, this PR should not be merged yet because the current “starter code” files are mostly documentation-style text blocks rather than actual runnable starter implementations.

For DevPath, starter files should provide meaningful executable scaffolding such as:

  • starter functions/classes
  • minimal Flask/app structure
  • placeholder logic
  • TODO-based implementation guidance
  • runnable project skeletons

Right now, files like:

  • movie_recommender.py
  • sentiment_app.py

mainly contain descriptive text and roadmap explanations inside Python files, which reduces their usefulness as actual starter code.

Additional concerns:

  • difficulty calibration may be slightly too advanced for “Intermediate”
  • resources could be more roadmap-specific
  • dataset rendering/filter behavior should be validated before merge

Please revise the starter code files to include real executable scaffolding and more practical implementation structure instead of primarily documentation text.

Once improved, the PR can be re-reviewed.

@komalharshita komalharshita added need review Further information is requested gssoc-2026 labels May 24, 2026
@iscompg
Copy link
Copy Markdown
Author

iscompg commented May 27, 2026

okay i'll add material to the starter_code files also make the remaining changes!

@iscompg iscompg force-pushed the data/add-intermediate-projects branch from 5578cdb to f29b04b Compare May 29, 2026 06:03
@iscompg
Copy link
Copy Markdown
Author

iscompg commented May 29, 2026

hi, @komalharshita , ive made the changes according to what was asked!

Updated the PR based on the review feedback.

Changes made:

  1. Expanded both starter_code files into runnable starter implementations
  2. Added modular scaffold functions and TODO guidance
  3. Refined project descriptions and roadmap steps for better intermediate-level calibration
  4. Synced the branch with the latest upstream changes and resolved conflicts

All tests are passing locally.

Screenshot 2026-05-29 at 10 48 42 AM

Copy link
Copy Markdown
Owner

@komalharshita komalharshita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the requested changes.

I reviewed the updated PR and the concerns from the previous review have been resolved.

Improvements verified:

  • Starter code files now contain executable scaffolding instead of primarily documentation text.
  • Both projects include meaningful starter functions, sample datasets, TODO guidance, and runnable structures.
  • Project descriptions, resources, and roadmaps have been improved.
  • The contribution remains well-scoped to the linked issue.
  • Merge conflicts have been resolved.

The Movie Recommendation System and Sentiment Analysis Web App are relevant additions to the Data track and provide good intermediate-level learning options for users.

Approved. Nice improvement and thank you for updating the implementation based on review feedback.

@komalharshita komalharshita merged commit f741fe0 into komalharshita:main Jun 1, 2026
14 of 15 checks passed
@komalharshita komalharshita added enhancement New feature or request level:intermediate quality:exceptional gssoc:approved and removed need review Further information is requested labels Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: add few more intermediate projects for better options

2 participants