data: add intermediate projects#157
Conversation
|
@iscompg is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@iscompg resolve the merge conflicts |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Adding intermediate-level projects is a valuable improvement for DevPath, and the selected project ideas are relevant and educational.
However, after review, this PR should not be merged yet because the current “starter code” files are mostly documentation-style text blocks rather than actual runnable starter implementations.
For DevPath, starter files should provide meaningful executable scaffolding such as:
- starter functions/classes
- minimal Flask/app structure
- placeholder logic
- TODO-based implementation guidance
- runnable project skeletons
Right now, files like:
movie_recommender.pysentiment_app.py
mainly contain descriptive text and roadmap explanations inside Python files, which reduces their usefulness as actual starter code.
Additional concerns:
- difficulty calibration may be slightly too advanced for “Intermediate”
- resources could be more roadmap-specific
- dataset rendering/filter behavior should be validated before merge
Please revise the starter code files to include real executable scaffolding and more practical implementation structure instead of primarily documentation text.
Once improved, the PR can be re-reviewed.
|
okay i'll add material to the starter_code files also make the remaining changes! |
5578cdb to
f29b04b
Compare
|
hi, @komalharshita , ive made the changes according to what was asked! Updated the PR based on the review feedback. Changes made:
All tests are passing locally.
|
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for addressing the requested changes.
I reviewed the updated PR and the concerns from the previous review have been resolved.
Improvements verified:
- Starter code files now contain executable scaffolding instead of primarily documentation text.
- Both projects include meaningful starter functions, sample datasets, TODO guidance, and runnable structures.
- Project descriptions, resources, and roadmaps have been improved.
- The contribution remains well-scoped to the linked issue.
- Merge conflicts have been resolved.
The Movie Recommendation System and Sentiment Analysis Web App are relevant additions to the Data track and provide good intermediate-level learning options for users.
Approved. Nice improvement and thank you for updating the implementation based on review feedback.

Summary [required]
Added two intermediate level projects for "data":
Also added starter_code scaffold files for both with basic idea in comments and roadmap
Related Issue [required]
add few more intermediate projects for better options (Issue #68)
Closes #68
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
data/projects.jsonstarter_code/movie_recommender.pystarter_code/sentiment_app.pyHow to Test This PR [required]
git checkout data/add-intermediate-projectspip install -r requirements.txtpython tests/test_basic.pyExpected test output:
Test Results [required]
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
starter_code files currently contain introductory scaffolding and roadmap guidance. Detailed implementations can be expanded in future contributions.