Skip to content

HttpUnitUtils does not check the validity of input String #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emopers wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HttpUnitUtils does not check the validity of input String #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/com/meterware/httpunit/HttpUnitUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ public static boolean isEclipse() {
public static String[] parseContentTypeHeader( String header ) {
String[] result = new String[] { "text/plain", null };
StringTokenizer st = new StringTokenizer( header, ";=" );
if (!st.hasMoreTokens()) {
throw new IllegalArgumentException( "Attempting to parse invalid header" );
}
result[0] = st.nextToken();
while (st.hasMoreTokens()) {
String parameter = st.nextToken();
Expand Down Expand Up @@ -458,4 +461,4 @@ public static boolean setEXCEPTION_DEBUG(boolean exception_debug) {
EXCEPTION_DEBUG = exception_debug;
return oldExceptionDebug;
}
}
}
11 changes: 11 additions & 0 deletions test/com/meterware/httpunit/EncodingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,17 @@ public void testParseContentHeader() throws Exception {
}


public void testParseEmptyHeader() throws Exception {
String invalidHeader = "";
try {
String result[]=HttpUnitUtils.parseContentTypeHeader(invalidHeader);
fail();
} catch (IllegalArgumentException iae) {
assertEquals( "header", "Attempting to parse invalid header" , iae.getMessage() );
}
}


public void testSpecifiedEncoding() throws Exception {
String hebrewTitle = "\u05d0\u05d1\u05d2\u05d3";
String page = "<html><head><title>" + hebrewTitle + "</title></head>\n" +
Expand Down