Skip to content

Improve HeatMap display #52

Open
MathijsR94 wants to merge 5 commits intomainfrom
fix/heatmap
Open

Improve HeatMap display #52
MathijsR94 wants to merge 5 commits intomainfrom
fix/heatmap

Conversation

@MathijsR94
Copy link
Copy Markdown
Collaborator

Summary

  • Filter out future weeks from the HeatMap so empty trailing columns aren't rendered
  • Restructure tooltip handlers to use cached layout measurements instead of per-event getBoundingClientRect calls
  • Add touch support (onTouchEnd) with toggle behavior and outside-tap dismissal
  • Memoize cell rendering into a cells variable
  • Add JSDoc to non-obvious interfaces and helpers

Test plan

  • Verify HeatMap does not show empty columns for future weeks
  • Hover cells on desktop — tooltip follows cursor and dismisses on mouse leave
  • Click a cell — tooltip toggles on/off
  • Tap a cell on mobile/touch device — tooltip toggles, tapping outside dismisses
  • Resize the browser and confirm tooltip positioning remains accurate

@MathijsR94 MathijsR94 requested a review from brdv March 29, 2026 11:08
@MathijsR94 MathijsR94 added the ui & polish Visual refinements and animations label Mar 29, 2026
@brdv
Copy link
Copy Markdown
Collaborator

brdv commented Mar 29, 2026

Hmm not really sure how i feel about this. Somewhere i do like the empty cols when a whole year is rendered (For this year. Give you some sense of what's left.

Also, this only happens on 'this year' and custom dates into the future, right?

Maybe changing the default range to 'last 12' months, like GH does makes more sense?

@MathijsR94
Copy link
Copy Markdown
Collaborator Author

Hmm not really sure how i feel about this. Somewhere i do like the empty cols when a whole year is rendered (For this year. Give you some sense of what's left.

Also, this only happens on 'this year' and custom dates into the future, right?

Maybe changing the default range to 'last 12' months, like GH does makes more sense?

Fair! Changed the heatmap to show the empty cols too. And added the 'last 12 months' filter. Bonus: now Toolbar and SettingsDrawer share the same date preset selection and will change together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui & polish Visual refinements and animations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants