uECC_vli_mmod: Avoid potential buffer overrun#182
Open
kjbracey wants to merge 1 commit intokmackay:masterfrom
Open
uECC_vli_mmod: Avoid potential buffer overrun#182kjbracey wants to merge 1 commit intokmackay:masterfrom
kjbracey wants to merge 1 commit intokmackay:masterfrom
Conversation
The shifting copy of `mod` into `mod_multiple` would overrun the destination if the high word of `mod` was zero, so `word_shift` > `num_words`. This is not the case for any curve p or n, but this part of the code is written as if to support arbitrary `mod`, comment disclaimer notwithstanding. Issue was detected via a static analysis tool. Alternative would be to reduce the genericness and just use `vli_numDigits` on the high word to get `bit_shift`, and use `num_words` as `word_shift`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shifting copy of
modintomod_multiplewould overrun the destination if the high word ofmodwas zero, soword_shift>num_words.This is not the case for any curve p or n, but this part of the code is written as if to support arbitrary
mod, comment disclaimer notwithstanding.Issue was detected via a static analysis tool.
Alternative would be to reduce the genericness and just use
vli_numDigitson the high word to getbit_shift, and usenum_wordsasword_shift.