chore(go-ci): bump nox 1.1.2→1.3.1, default cross-platform off#19
Merged
Conversation
- nox 1.1.2 -> 1.3.1 (+ sha256 of nox_1.3.1_linux_amd64.tar.gz). Picks up the docker-batch OSV fix, degraded-lookup warning, and V2 fingerprints every caller already wanted; Nexa was running 1.3.x out-of-band. - cross-platform now defaults FALSE. The macOS (10x) + Windows (2x) matrix ran on every push-to-main for every adopter, including pure-logic libs that have no OS-specific code. Opt in per-repo (cross-platform: true) for the few that need it (storage engines, terminal/syscall code). Reduces push-to-main runner minutes org-wide; callers inherit on next run.
There was a problem hiding this comment.
Pull request overview
Updates the shared reusable Go CI workflow (.github/workflows/go-ci.yml) to align the default nox scanner version with current org usage and to reduce CI cost by disabling cross-platform test matrices unless explicitly enabled by callers.
Changes:
- Bump the default pinned
noxrelease from1.1.2to1.3.1and update the correspondingsha256input default. - Change
cross-platforminput default fromtruetofalseand clarify the input description to encourage opt-in only for OS-specific code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cost/best-practice fixes to the shared reusable Go CI (
go-ci.yml), inherited by every caller on next run.nox 1.1.2 → 1.3.1
Bumps the pinned nox binary (+ sha256 of
nox_1.3.1_linux_amd64.tar.gz=72a301bd…953abb, from the releasechecksums.txt). Picks up the docker-batch OSV fix, the degraded-lookup warning, and V2 line-independent fingerprints. Nexa was already running 1.3.x out-of-band; this aligns the org default.cross-platformdefault true → falseThe macOS (10× runner cost) + Windows (2×) test matrix ran on every push-to-main for every adopter, including pure-logic libraries with no OS-specific code. Now off by default; repos with OS-specific code (storage engines, syscalls, terminal handling) opt in with
cross-platform: true. Pure logic is identical on all three OSes, so this drops a large slice of push-to-main minutes org-wide at no coverage loss.No caller changes required.