ci(security): drop gosec from golden golangci config#18
Merged
Conversation
nox now owns all code-level security. Its cosign-verified taint-analysis
plugin (community trust, enforced in go-ci.yml) covers the taint rules
gosec provided (G703/G704/G706 — SSRF, path traversal, injection), and
nox's core ruleset covers gosec's credential/crypto/file-perm checks. The
deferral note ("keep gosec until nox/taint-analysis is verified") is now
satisfied across the org, so gosec is removed from the reference linter
set, settings and exclusions. Routes any code-security gap through nox.
There was a problem hiding this comment.
Pull request overview
Removes gosec from the organization’s reference golangci-lint configuration now that code-level security/taint scanning is handled by nox (via the enforced nox/taint-analysis plugin in the shared Go CI workflow).
Changes:
- Dropped
gosecfrom the reference linter enable list. - Removed
gosec-specific configuration (settings.gosec) and its related exclusion rule. - Updated the header/security note and linter rationale comments to reflect
noxas the sole code-level security scanner.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nox now owns all code-level security org-wide.
nox/taint-analysis(cosign-verified, community trust, enforced in go-ci.yml) covers gosec's taint rules (G703/G704/G706); nox core covers credential/crypto/file-perm. The "keep gosec until taint verified" deferral is satisfied — taint is live across all 11 repos. Removes gosec from the referenceenable,settings.gosecandexclusions.rules.golangci-lint config verifypasses.