spike on testing a bunch of files from the MPEG file format set #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh
force-pushed
the
mpeg_conformance_spike2_2026-01-09
branch
from
c8df672 to
3be69dc
Compare
This is required in HEIF image sequences (i.e. a track with `pict` as the handler), per ISO/IEC 23008-12.
nmhd is the null media header box, and is used for metadata and text tracks (14496-12, Sections 8.4.5.2, 12.3.2 and 12.5.2 sthd is the subtitle header box (14496-12, Section 12.6.2) These boxes are very similar, and the test changes would affect both.
This is from ISO/IEC 23008-12:2025 Section 7.4. Its used in HEIF image sequences. This fixes the parsing of the several of the old HEIF samples in the MPEG File Format Conformance suite. Without this change, we get OverDecode errors for `sgpd`.
bradh
force-pushed
the
mpeg_conformance_spike2_2026-01-09
branch
from
3be69dc to
c000b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few that don't work yet,
tx3g,stsz,mfra,ssixbeing the candidate missing boxes.