-
Notifications
You must be signed in to change notification settings - Fork 2k
ffmpeg, python3: include executable
#3276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
5049854 to
4e749d1
Compare
ffmpeg: include executableffmpeg, python3: include executable
e6265c9 to
88c6be8
Compare
| files_dir = mActivity.getFilesDir().getAbsolutePath() | ||
| bin_dir = join(files_dir, 'app', '.bin') | ||
|
|
||
| if not isdir(bin_dir): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makedirs(path, exist_ok=True) so if statement is not needed
| if isfile(_exe_lib) and not islink(_exe): | ||
| try: | ||
| os.symlink(_exe_lib, _exe) | ||
| print(f'Symlink executable: {exe_lib} -> {exe}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of print, try using logging instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think that would be overkill.
This would require to setup logger in android module itself, which will increase startup time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice having. And perhaps add logging for the rest of the file. I don't think a setup is actually needed so python can automatically deal with it
Closes #3137
Notes:
pythonbinary is just 8KBffmpegbinary is about 252K or around 0.25MBTest code:
Expected Output: