Add ModelPack created annotation to manifests#1164
Open
gnanirahulnutakki wants to merge 1 commit intokitops-ml:mainfrom
Open
Add ModelPack created annotation to manifests#1164gnanirahulnutakki wants to merge 1 commit intokitops-ml:mainfrom
gnanirahulnutakki wants to merge 1 commit intokitops-ml:mainfrom
Conversation
Signed-off-by: Gnani Rahul <gnutakki@radiantlogic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1138
This adds
org.opencontainers.image.createdto ModelPack manifests only, and it reuses the sameCreatedAtvalue already emitted into the ModelPack config instead of minting a second timestamp at manifest creation time. That keeps the manifest aligned with the existing ModelPack metadata while leaving KitFormat behavior unchanged.Validation:
go test ./pkg/lib/filesystem -run TestCreateManifestgo build ./...go generate ./...(completed locally; the harness UI generator emittedpnpmwarnings in this environment but produced no tracked source changes)