Updated Highcharts from 6.0.4 to 7.0.2#433
Open
noumanaltaf wants to merge 4 commits intokirjs:masterfrom
Open
Conversation
|
I would also be interested in this! If you need any help or support, just let me know! 👍 |
|
I just had a closer look at this PR again and it looks to be in a very early stage, for example some files are added that should not be added. @noumanaltaf are you still working on this? |
Open
|
how do we update this? trying to update to version 8 |
|
this isn't a clean upgrade path. This pull request should be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highcharts version updated from 6.0.4 to 7.0.2
And also updated package name to avoid name conflict on npm.
Suggestion : Please move highcharts from dependencies to peer dependencies to minimize scenarios like this.