Wrap OSC 777 in tmux DCS passthrough when running inside tmux#2
Open
yonilerner wants to merge 1 commit into
Open
Wrap OSC 777 in tmux DCS passthrough when running inside tmux#2yonilerner wants to merge 1 commit into
yonilerner wants to merge 1 commit into
Conversation
When the extension runs in a pi session inside tmux, the OSC 777 escape sequence written to stdout is consumed by tmux instead of being forwarded to the host terminal (Ghostty, iTerm2, etc.), so no notification ever fires. Detect TMUX via process.env.TMUX and wrap the sequence in tmux's DCS passthrough format (ESC P tmux ; ESC <seq> ESC \\ with embedded ESCs doubled). Requires `set -g allow-passthrough on` in tmux.conf, which is on by default in tmux >= 3.3a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pi-notify-pp runs inside tmux, the OSC 777 escape sequence written to stdout is consumed by tmux instead of being forwarded to the host terminal (Ghostty, iTerm2, etc.), so no notification ever fires.
This patch detects
process.env.TMUXand wraps the sequence in tmux's DCS passthrough format (ESC P tmux ; ESC <seq> ESC \\with embedded ESCs doubled) so the host terminal receives the OSC normally.Requires
set -g allow-passthrough onin tmux.conf — which is the default since tmux 3.3a. Outside of tmux, behavior is unchanged.