fix(ui): clear popover background before rendering#57
Merged
Conversation
The params-prompt and saved-query picker overlays were rendering on top of the editor, but `Block::style(bg)` only sets the cell style — it doesn't overwrite the glyph already in the buffer. That left the editor characters showing through the popover. Explicitly clear the popover rect and repaint with the theme bg before drawing the block. Bump to 0.17.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Block::style(bg)only sets each cell's style — it doesn't overwrite the symbol already in the buffer, so editor characters bled through the popover.Clearthe popover rect and repaint cells with the theme bg/fg before drawing the block.Test plan
cargo fmt && cargo clippy --all-targets -- -D warnings && cargo test:run-saved(bare) → picker overlay shows a solid background over the editor