This repository was archived by the owner on Aug 21, 2025. It is now read-only.
KIBA-1572: Create tbl_account_ens_names#443
Open
Femi-Ogunkola wants to merge 20 commits into
Open
Conversation
Femi-Ogunkola
commented
Sep 23, 2022
Femi-Ogunkola
commented
Sep 24, 2022
| await self.saver.delete_account_ens_name(accountEnsNameId=accountEnsName.accountEnsNameId, connection=connection) | ||
| ensName = await self.accountEnsNameProcessor.get_ens_name(accountAddress=accountAddress) | ||
| accountEnsName = await self.saver.create_account_ens_name(accountAddress=accountAddress, ensName=ensName, connection=connection) | ||
| print(accountEnsName) |
| row = result.first() | ||
| if not row: | ||
| raise NotFoundException(message=f'AccountCollectionGm for accountAddress: {accountAddress} not found') | ||
| accountCollectionGm = account_ens_name_from_row(row) |
Contributor
Author
There was a problem hiding this comment.
rename accountEnsName
| if accountEnsName: | ||
| if accountEnsName.ensName and accountEnsName.updatedDate > date_util.datetime_from_now(days=-3): | ||
| return accountEnsName | ||
| await self.saver.delete_account_ens_name(accountEnsNameId=accountEnsName.accountEnsNameId, connection=connection) |
Contributor
Author
There was a problem hiding this comment.
Update don't delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.