Fix: remove polyfill package#121
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the vite-plugin-node-polyfills integration (and its custom shim/alias workaround) from the React App Vite build config, and adjusts Rolldown’s code-splitting behavior.
Changes:
- Remove
vite-plugin-node-polyfillsusage fromscripts/react-app-vite/app.config.js, including the customnode:moduleshim and shim alias resolution workaround. - Delete the now-unused
scripts/react-app-vite/moduleShim.js. - Drop
vite-plugin-node-polyfillsfrom dependencies/lockfile, and enableincludeDependenciesRecursivelyfor Rolldown code splitting.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/react-app-vite/moduleShim.js | Removes the browser stub shim for node:module (file deleted). |
| scripts/react-app-vite/app.config.js | Removes node polyfill plugin + related shim alias plumbing; tweaks Rolldown code-splitting recursion. |
| package.json | Removes vite-plugin-node-polyfills from dependencies. |
| package-lock.json | Removes transitive dependencies pulled in by vite-plugin-node-polyfills. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
43
to
47
| return defineConfig({ | ||
| plugins: [ | ||
| pluginReactSwc(), | ||
| nodePolyfills({ | ||
| // NOTE(krishan711): Use 'build' only for globals to avoid shim resolution issues in dev. | ||
| // See: https://github.com/davidmyersdev/vite-plugin-node-polyfills/issues/140 | ||
| globals: { | ||
| Buffer: 'build', | ||
| global: 'build', | ||
| process: 'build', | ||
| }, | ||
| overrides: { | ||
| module: moduleShimPath, | ||
| }, | ||
| }), | ||
| createShimsResolverPlugin(), | ||
| ...(params.addHtmlOutput ? [createIndexPlugin({ templateFilePath: indexTemplateFilePath, name, entryFilePath: params.entryFilePath })] : []), | ||
| ...(params.addRuntimeConfig ? [createRuntimeConfigPlugin({ vars: runtimeConfigVars })] : []), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: