Two-sided scale-use / offset bands on the panel scorecard#435
Open
kgdunn wants to merge 2 commits into
Open
Conversation
panel_scorecard now labels each panelist low/normal/high on scale use and on offset via Tukey 1.5*IQR fences, surfacing both tails symmetrically so a compressor is reported like an expander. The bands ride on the scorecard table and are exposed through sensory_panel_check and a new scale_bands block in sensory_analyze_descriptive, so a front-end can colour a panel map from a stable classification instead of re-deriving thresholds. Bump to 1.52.0.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A front-end colouring a panel-consistency chart currently has to re-derive its
own thresholds from the raw
scale_spread/scale_shiftnumbers to decide whocompresses, stretches, or rates high/low. Doing that on the magnitude alone
tends to paint the whole panel as a problem, and it easily reports one tail (say
expanders) while dropping the other (compressors).
This adds a stable, symmetric classification the panel check computes once, so
the front-end can bind to it instead.
What changed
panel_scorecardnow adds two columns per panelist:scale_use_band-low(compresses the range) /normal/high(expands the range),
offset_band-low(rates consistently low) /normal/high(ratesconsistently high).
Both use two-sided Tukey 1.5*IQR fences, so the two tails are surfaced
symmetrically. The fence is intentionally looser than the ESD test used for
dropping, because scale use and offset are corrected by alignment rather than
dropped; the aim is to surface the genuine tails, not withhold all but the most
extreme.
sensory_panel_checkcarries the two bands oneach scorecard row, and
sensory_analyze_descriptivegains ascale_bandsblock (
panelist_id,scale_use_band,offset_band). Both tool descriptionsdocument the new fields and how to use them (colour / label only the non-normal
panelists).
Tests / verification
New unit tests assert the band columns exist and classify a planted expander as
high, a compressor aslow, a typical panelist asnormal, and a high rateras
highon offset; the analyze-tool test checks thescale_bandsblock isexposed.
ruff,mypy, and the sensory + recipe suites pass. Version bumped to1.52.0 with CITATION and CHANGELOG in sync.
Generated by Claude Code