Open
Conversation
XhmikosR
commented
Jan 12, 2022
| strip: this.options.strip, | ||
| }))).then(result => { | ||
| const resultingFiles = flatten(result.map((item, index) => { | ||
| const resultingFiles = result.flatMap((item, index) => { |
Contributor
Author
There was a problem hiding this comment.
Switched this to flatMap and removed the custom flatten function, but I could use a confirmation.
XhmikosR
commented
Jan 12, 2022
| "xo": "xo", | ||
| "test": "npm run xo && npm run ava" | ||
| }, | ||
| "main": "index.js", |
Contributor
Author
There was a problem hiding this comment.
Unsure if main is even needed anymore
XhmikosR
force-pushed
the
dev
branch
4 times, most recently
from
ab3a2dd to
1550099
Compare
XhmikosR
force-pushed
the
dev
branch
3 times, most recently
from
83aca3b to
b7ee8a0
Compare
XhmikosR
force-pushed
the
dev
branch
2 times, most recently
from
636463a to
53bcdf3
Compare
|
Hi @XhmikosR! Could this PR be merged? 🙏🏼 This PR updates the ─┬ bin-wrapper@4.1.0 Thank you! 😊 |
Contributor
Author
|
I don't have push/npm rights. Also see #79 (comment) |
Also, add coverage with c8
jen801
reviewed
Jan 1, 2023
| * @api public | ||
| */ | ||
| module.exports = class BinWrapper { | ||
| export default class BinWrapper { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sindresorhus friendly ping for review :)
Let me know if something could be improved, I haven't switched many projects to ESM yet.
CI run since it doesn't run yet on this repo: https://github.com/XhmikosR/bin-wrapper/actions
Closes #77, refs #79