Adding advanced search. Fixes issue #216. #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements advanced search functionality for Companies House, addressing issue #216. The implementation introduces a new advanced search capability that supports filtering companies by multiple criteria beyond the basic query string search.
- Refactors existing search infrastructure to support both query-based and advanced search patterns
- Adds comprehensive advanced search functionality with support for company name includes/excludes, status, type, incorporation dates, location, and SIC codes
- Includes extensive test coverage for all advanced search parameters
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| AdvancedSearchCompanyRequest.cs | New request model defining all advanced search parameters |
| AdvancedSearchCompanyUriBuilder.cs | URI builder implementing query string construction for advanced search |
| SearchUriBuilder.cs | Refactored base class with improved parameter handling and enum serialization |
| SearchRequest.cs | Refactored to separate query-based and general search request interfaces |
| CompaniesHouseClient.cs | Added SearchCompanyAdvancedAsync method to main client interface |
| Various test files | Comprehensive test coverage for all advanced search scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated Dockerfile to use uppercase 'AS' for build stages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding advanced search.
Fixes issue #216.