Conversation
Signed-off-by: unknown <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com> Signed-off-by: unknown <iampranshu24@gmail.com>
Signed-off-by: unknown <iampranshu24@gmail.com>
Signed-off-by: re-Tick <jain.ritik.1001@gmail.com> Signed-off-by: unknown <iampranshu24@gmail.com>
Signed-off-by: unknown <iampranshu24@gmail.com>
PranshuSrivastava
force-pushed
the
grpc_implementation
branch
from
fc78c5a to
1563b09
Compare
Signed-off-by: unknown <iampranshu24@gmail.com>
Signed-off-by: unknown <iampranshu24@gmail.com>
keploy/keploy.go
Outdated
| k.setKey(r) | ||
| r.Header.Set("Content-Type", "application/json") | ||
| if k.cfg.Server.GrpcEnabled { | ||
| r, err := k.grpcClient.Test(k.Ctx, &proto.TestReq{ |
There was a problem hiding this comment.
Since, there are HTTP and GRPC_EXPORT types of tcs. Therefore, it should have proto.TestReq.GrpcResp field when tcs type is GRPC_EXPORT.
keploy/keploy.go
Outdated
| k.setKey(r) | ||
| r.Header.Set("Content-Type", "application/json") | ||
| if k.cfg.Server.GrpcEnabled { | ||
| _, err = k.grpcClient.DeNoise(k.Ctx, &proto.TestReq{ |
There was a problem hiding this comment.
Here, also it should have proto.TestReq.GrpcResp field assigned when tcs is of type GRPC_EXPORT.
Signed-off-by: unknown <iampranshu24@gmail.com>
| _, err = k.grpcClient.DeNoise(k.Ctx, &proto.TestReq{ | ||
| ID: id, | ||
| AppID: k.cfg.App.Name, | ||
| Resp: &proto.HttpResp{ |
There was a problem hiding this comment.
Resp field is empty for testcase of type grpc
keploy/keploy.go
Outdated
| ID: tc.ID, | ||
| AppID: k.cfg.App.Name, | ||
| RunID: runId, | ||
| Resp: &proto.HttpResp{ |
There was a problem hiding this comment.
Please Resp field because this field stores response for http but in grpc, it should be empty.
o Signed-off-by: Ubuntu <ubuntu@ip-172-31-31-147.ap-south-1.compute.internal>
Signed-off-by: Ubuntu <ubuntu@ip-172-31-31-147.ap-south-1.compute.internal>
keploy/keploy.go
Outdated
| return nil | ||
| } | ||
| } else { | ||
| url := fmt.Sprintf("%s/regression/testcase?app=%s&offset=%d&limit=%d&testCasePath=%s&mockPath=%s&reqType=%s", k.cfg.Server.URL, k.cfg.App.Name, i, 25, k.cfg.App.TestPath, k.cfg.App.MockPath) |
There was a problem hiding this comment.
Please remove the reqType query parameter.
There was a problem hiding this comment.
Done. PTAL
Signed-off-by: Ubuntu <ubuntu@ip-172-31-31-147.ap-south-1.compute.internal>
Signed-off-by: Ubuntu <ubuntu@ip-172-31-31-147.ap-south-1.compute.internal>
|
To generate Unit Tests for this PR, please click here |
|
To generate Unit Tests for this PR, please click here |
|
To generate Unit Tests for this PR, please click here |
|
To generate Unit Tests for this PR, please click here |
|
To generate Unit Tests for this PR, please click here |
|
To generate Unit Tests for this PR, please click here |
|
To generate Unit Tests for this PR, please click here |
|
To generate Unit Tests for this PR, please click here |
|
To generate Unit Tests for this PR, please click here |
|
To generate Unit Tests for this PR, please click here |
2 participants
Giving an option to the user to use either grpc or http while creating tests and mocks. GrpcEnabled field, in the server config will be used to choose one of the options.
Closes #4