Add CRD design, API compatibility, and Helm gating conventions#786
Open
kelos-bot[bot] wants to merge 1 commit intomainfrom
Open
Add CRD design, API compatibility, and Helm gating conventions#786kelos-bot[bot] wants to merge 1 commit intomainfrom
kelos-bot[bot] wants to merge 1 commit intomainfrom
Conversation
Add three new agent conventions from recent PR review feedback: 1. Per-TaskSpawner configuration should be CRD fields, not controller flags (PR #838 - gjkim42 review) 2. CRD API backward compatibility - never rename JSON field tags (PR #838 - P1 review finding) 3. Gate optional CRDs behind Helm values flags (PR #821 - PodMonitoring broke installs on clusters without monitoring.googleapis.com) Also includes previously proposed conventions from PR #786: - Consistent guidance across surfaces - Provider-agnostic API design - Idiomatic Helm values - Deploy-dev workflow sync - Controller-driven migration - Release note user action requirements Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bcdeef3 to
7ade17e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
Adds agent conventions derived from recent PR review feedback, applied consistently across
CLAUDE.md/AGENTS.mdandself-development/agentconfig.yaml.New conventions (from this week's reviews):
PodMonitoring) must be gated behind a values flag so installs don't fail on clusters without those CRDs.Carried forward conventions (from prior reviews):
Evidence from PR reviews:
githubReadProxyBaseURLas a controller flag instead of a TaskSpawner CRD field)githubReadBaseURLintroduces a breaking API change without backward compatibility. Existing manifests usinggithubReadProxyBaseURLwill silently stop configuring the read proxy."kelos-systeminstead of workflow'sKELOS_NAMESPACEWhich issue(s) this PR is related to:
N/A
Special notes for your reviewer:
This PR replaces the previous content on this branch. All conventions are backed by specific PR review evidence listed above.
Does this PR introduce a user-facing change?