Skip to content

ensure disabled animations when multiple banners are loaded #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmmeon wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ensure disabled animations when multiple banners are loaded #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11b6f97
fix(banner.js): use selector to disable animations
mmmeon Mar 10, 2026
a3134ee
docs(banner.md): fix snippet to use tld with no id
mmmeon Mar 10, 2026
5062519
docs(banner.md): add line breaks between examples
mmmeon Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions public/banner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@
"}" +
".kao-banner-close:hover{opacity:1;}";

var cssKaoPulse =
".kao-banner { animation:kao-pulse 2s infinite; }" +
var cssKaoPulse =
".kao-banner:not(.no-animation) { animation:kao-pulse 2s infinite; }" +
"@keyframes kao-pulse{" +
"0%{box-shadow:0 0 0 0 rgba(211,47,47,0.7)}" +
"70%{box-shadow:0 0 0 15px rgba(211,47,47,0)}" +
Expand All @@ -217,8 +217,8 @@

var style = document.createElement("style");
style.textContent = (size === "mini" ? cssMini : size === "minimal" ? cssMinimal : cssNormal)
+ (params.animation === "off" ? "" : cssKaoPulse)
+ cssCommon;
+ (params.animation === "off" ? "" : cssKaoPulse)
+ cssCommon;
document.head.appendChild(style);

// ── Check if previously dismissed (reappears after dismissDays) ─────
Expand All @@ -235,7 +235,7 @@

// ── Create banner DOM ─────────────────────────────────────────────────
var banner = document.createElement("div");
banner.className = "kao-banner";
banner.className = params.animation === "off" ? "kao-banner no-animation" : "kao-banner";

var messageText = messages[locale] || messages.en;

Expand Down
5 changes: 4 additions & 1 deletion src/content/pages/banner.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ French, mini size, inserted into a specific element:
<div id="my-banner"></div>
<script src="/banner.js?lang=fr&size=mini&id=my-banner"></script>

---

Link to a custom page, no close button:

Expand All @@ -50,10 +51,12 @@ Link to a custom page, no close button:
<div id="my-banner-custom"></div>
<script src="/banner.js?link=https://example.com/android&hidebutton=off&size=mini&id=my-banner-custom"></script>

---

Minimal size without animations.

```html
<script src="/banner.js?size=minimal&animation=off&id=my-banner-minimal"></script>
<script src="https://keepandroidopen.org/banner.js?size=minimal&animation=off></script>
```
<div id="my-banner-minimal"></div>
<script src="/banner.js?size=minimal&animation=off&id=my-banner-minimal"></script>
Expand Down