Skip to content

add single line and animation options to banner#205

Merged
marcprux merged 4 commits intokeepandroidopen:mainfrom
mmmeon:main
Mar 9, 2026
Merged

add single line and animation options to banner#205
marcprux merged 4 commits intokeepandroidopen:mainfrom
mmmeon:main

Conversation

@mmmeon
Copy link
Contributor

@mmmeon mmmeon commented Mar 9, 2026

made an adjustment to the banner for myself, either of the two changes may be worth providing as a parameter options.

  • size = minimal: text on single line with wrapping
  • animation = off: no animation
example with both example with both

@marcprux
Copy link
Collaborator

marcprux commented Mar 9, 2026

This looks useful. Were the animations causing issues with your site, or did you just add the optional to disable them for aesthetic reasons?

Also, could you update the docs for the banner to include the new options: https://github.com/keepandroidopen/keepandroidopen.github.io/blob/main/src/content/pages/banner.md

@marcprux marcprux added the enhancement New feature or request label Mar 9, 2026
@mmmeon
Copy link
Contributor Author

mmmeon commented Mar 9, 2026

This looks useful. Were the animations causing issues with your site, or did you just add the optional to disable them for aesthetic reasons?

Bothered my eyes a bit next to a white background.

Also, could you update the docs for the banner to include the new options: https://github.com/keepandroidopen/keepandroidopen.github.io/blob/main/src/content/pages/banner.md

Will do.

add animation: on/off & size: minimal
@marcprux
Copy link
Collaborator

marcprux commented Mar 9, 2026

Thanks!

@marcprux marcprux merged commit e0b6edd into keepandroidopen:main Mar 9, 2026
2 checks passed
@mmmeon
Copy link
Contributor Author

mmmeon commented Mar 10, 2026

found an issue with my changes.
needed to add the domain to the example snippet.
also, the animation off implementation doesn't change the class, so if the animation css is injected for another banner it'll show for all.

i was going to change the documentation, but i should probably handle this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants