Add de-CH variant to supported locales#191
Add de-CH variant to supported locales#191Andre601 wants to merge 1 commit intokeepandroidopen:mainfrom
Conversation
|
The problem with this change is that the locale for the banner will by default link to the localized version of the page, so this would go to A better solution would be for the logic in the banner to provide fallbacks, so if there's no "de-CH" key, then it falls back to checking "de". |
|
I've implemented more robust locale detection in 4293d00, so "de-CH" should now fallback to "de". Please give it a try and reopen this PR (or create a new issue) if the locale still doesn't display correctly for you. |
|
Well... Not sure where or how exactly I should test it. The keepandroidopen site seems to you hardcoded languages for the banner, so looking at it on the en page shows EN version and de obviously de... I'm not really using it, as I don't have any project related, nor he cloud that would justify this, so I can't test it myself really... Also, yes, I did check the banner page itself. And if that one is dynamic, then it's not working I'm afraid. And in that case could it maybe be the browser returning a different code for the language? |
|
Can you check the output of 
|
Maybe it's a browser issue or privacy settings related? |
2 participants
The banner does not display the german translation if your browser/os uses german with swiss grammar (de-CH), so I added it.
It's effectively the same as german itself, so if there's a simpler way for less duplication lmk.