Improve localized countdown timer display#110
Merged
marcprux merged 1 commit intokeepandroidopen:mainfrom Feb 21, 2026
Merged
Conversation
Collaborator
|
Great improvement, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears some languages — so far as
Intl.RelativeTimeFormatis concerned — actually utilize a suffix (which probably transliterates into something like2 days later) vis-à-vis English which utilizes a conjunction ie prefix (egin 2 days). The proposed MR tries to take care of that by essentially, out of the four components (d:h:m:s) in the countdown banner, showing only the prefix for the first component and, where applicable, the suffix for the last component, so that it probably reads more natural to the reader.