Masaki#3
Open
kedaitinh12 wants to merge 10 commits into
Open
Conversation
Previously, texture yoffset is affected by the bottom edge of a rectangular clip, which can cause unexpected textures when using rect clip tag, especially iclips, with $img tag.
…used by passing RGB24 format clip
This commit implements the standard CSRI_EXT_STREAM_ASS extension in VSFilterMod, allowing callers (like xy-VSFilter) to feed subtitle packets dynamically instead of loading the entire file upfront. Key changes: - Included standard `csri/stream.h` and exposed the stream extension via `csri_query_ext`. - Implemented `vsfilter_init_stream`, `vsfilter_push_packet`, and `vsfilter_discard` to support standard streaming operations. - Added `m_sver` (script version) to `CSimpleTextSubtitle` and persisted it during header parsing (in `STS.cpp`). - Fixed fragile ASS/ASS2 format detection in `push_packet`: Instead of naively counting commas per packet (which broke on ASS tags like `\pos(x,y)`), it now reliably checks `m_sver >= 6` from the parsed header to determine if 9 or 10 fields are expected. - Replaced the non-existent `RemoveAllEntries()` with `RemoveAll()` and `CreateSegments()` in the stream discard logic to properly clear the render queue.
2f96a4b to
ce77407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.