Skip to content

chore(doctrine-retry-bundle): AJDA-2222 upgrade to Symfony 8 and Doctrine Bundle 3#535

Open
odinuv wants to merge 11 commits into
mainfrom
odin-AJDA-2222
Open

chore(doctrine-retry-bundle): AJDA-2222 upgrade to Symfony 8 and Doctrine Bundle 3#535
odinuv wants to merge 11 commits into
mainfrom
odin-AJDA-2222

Conversation

@odinuv

@odinuv odinuv commented Jun 27, 2026

Copy link
Copy Markdown
Member

Link to issue

https://linear.app/keboola/issue/AJDA-2222/update-doctrine-in-editor-service

Description

doctrine-retry-bundle was pinned to doctrine/doctrine-bundle ^2.1 and Symfony ^7.0|^6.4, which prevents consumers (the editor service) from moving to Symfony 8 — doctrine-bundle 2.x is incompatible with symfony/var-exporter 8.x. This bumps the bundle's dependency stack so it installs cleanly on Symfony 8:

  • doctrine/doctrine-bundle^3.0, Symfony components → ^8.0|^7.4.
  • Dev tooling: PHPUnit → ^13.0, keboola/coding-standard^16.0, added phpstan-doctrine and phpstan-symfony extensions.
  • PHPUnit and PHPStan config updated for the new major versions (phpunit.xml.dist schema 13.0 / <source> element, phpstan.neonphpstan.neon.dist); Rector/coding-standard pass applied to src/tests.
  • Tests now load env via symfony/dotenv (optional .env.local) and validate the required TEST_DATABASE_* / TEST_PROXY_HOST variables in bootstrap.php; README documents the Toxiproxy-backed setup and the docker compose run one-liner.

No runtime behavior change — the retry driver logic is unchanged aside from a type-hint added for static analysis.

Justification

See the linked Linear issue: unblocks the Symfony 8 / Doctrine upgrade of the editor service.

Plans for Customer Communication

None.

Impact Analysis

Library-only change; affects consumers that depend on keboola/doctrine-retry-bundle. The minimum supported Symfony/doctrine-bundle versions move up (Symfony 7.4+, doctrine-bundle 3.x), so consumers still on Symfony 6.4 / doctrine-bundle 2.x cannot take the new release — this is intentional. No feature flag.

Deployment Plan

Release a tagged version.

Rollback Plan

Revert this PR.

Post-Release Support Plan

None.

@linear

linear Bot commented Jun 27, 2026

Copy link
Copy Markdown

AJDA-2222

@odinuv odinuv changed the title Odin ajda 2222 chore(doctrine-retry-bundle): AJDA-2222 upgrade to Symfony 8 and Doctrine Bundle 3 Jun 27, 2026
@odinuv odinuv requested a review from ondrajodas June 27, 2026 09:57
@odinuv odinuv marked this pull request as ready for review June 27, 2026 09:57

@keboola-pr-reviewer-bot keboola-pr-reviewer-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: needs_human (risk 3/5) · profile ajda

This PR intentionally raises minimum supported versions in a platform-libraries shared library, making it a backward-incompatible change that needs human review.

Concerns:

  • libs/doctrine-retry-bundle/composer.json: Production require bumped by a major version (doctrine-bundle 2→3, Symfony 7→8); major bumps are not auto-safe per policy.
  • libs/doctrine-retry-bundle/composer.json: Intentional BC break for consumers on Symfony <7.4 / doctrine-bundle 2.x; platform-libraries BC breaks require human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants