chore(doctrine-retry-bundle): AJDA-2222 upgrade to Symfony 8 and Doctrine Bundle 3#535
Open
odinuv wants to merge 11 commits into
Open
chore(doctrine-retry-bundle): AJDA-2222 upgrade to Symfony 8 and Doctrine Bundle 3#535odinuv wants to merge 11 commits into
odinuv wants to merge 11 commits into
Conversation
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 3/5) · profile ajda
This PR intentionally raises minimum supported versions in a platform-libraries shared library, making it a backward-incompatible change that needs human review.
Concerns:
libs/doctrine-retry-bundle/composer.json: Productionrequirebumped by a major version (doctrine-bundle 2→3, Symfony 7→8); major bumps are not auto-safe per policy.libs/doctrine-retry-bundle/composer.json: Intentional BC break for consumers on Symfony <7.4 / doctrine-bundle 2.x; platform-libraries BC breaks require human review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
https://linear.app/keboola/issue/AJDA-2222/update-doctrine-in-editor-service
Description
doctrine-retry-bundlewas pinned todoctrine/doctrine-bundle ^2.1and Symfony^7.0|^6.4, which prevents consumers (the editor service) from moving to Symfony 8 — doctrine-bundle 2.x is incompatible withsymfony/var-exporter8.x. This bumps the bundle's dependency stack so it installs cleanly on Symfony 8:doctrine/doctrine-bundle→^3.0, Symfony components →^8.0|^7.4.^13.0,keboola/coding-standard→^16.0, addedphpstan-doctrineandphpstan-symfonyextensions.phpunit.xml.distschema 13.0 /<source>element,phpstan.neon→phpstan.neon.dist); Rector/coding-standard pass applied tosrc/tests.symfony/dotenv(optional.env.local) and validate the requiredTEST_DATABASE_*/TEST_PROXY_HOSTvariables inbootstrap.php; README documents the Toxiproxy-backed setup and thedocker compose runone-liner.No runtime behavior change — the retry driver logic is unchanged aside from a type-hint added for static analysis.
Justification
See the linked Linear issue: unblocks the Symfony 8 / Doctrine upgrade of the editor service.
Plans for Customer Communication
None.
Impact Analysis
Library-only change; affects consumers that depend on
keboola/doctrine-retry-bundle. The minimum supported Symfony/doctrine-bundle versions move up (Symfony 7.4+, doctrine-bundle 3.x), so consumers still on Symfony 6.4 / doctrine-bundle 2.x cannot take the new release — this is intentional. No feature flag.Deployment Plan
Release a tagged version.
Rollback Plan
Revert this PR.
Post-Release Support Plan
None.