test(doctrine-retry-bundle): AJDA-2222 load test env via dotenv and document setup#534
Open
odinuv wants to merge 2 commits into
Open
test(doctrine-retry-bundle): AJDA-2222 load test env via dotenv and document setup#534odinuv wants to merge 2 commits into
odinuv wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
https://linear.app/keboola/issue/AJDA-2222/update-doctrine-in-editor-service
Description
Reworks the doctrine-retry-bundle test setup to load configuration from a
.envfile viasymfony/dotenvand fail fast when required variables are missing. The test bootstrap now boots the env and asserts thatTEST_DATABASE_HOST,TEST_DATABASE_PORT,TEST_DATABASE_USER,TEST_DATABASE_PASSWORD,TEST_DATABASE_DBandTEST_PROXY_HOSTare present, replacing the singleTEST_DATABASE_URL. The README documents the new variables and thedocker compose run --rm dev-doctrine-retry-bundle composer ciflow (MySQL + Toxiproxy).Justification
See the linked Linear issue — needed to align the bundle's test setup while updating Doctrine in the editor service.
Plans for Customer Communication
None.
Impact Analysis
Test-only change. No runtime/production code is affected and there is no behavior change for consumers of the bundle. Adds
symfony/dotenvas a dev dependency.Deployment Plan
Release a tagged version.
Rollback Plan
Revert this PR.
Post-Release Support Plan
None.