feat(input-mapping): AJDA-2714 read description from table definition#533
Draft
odinuv wants to merge 1 commit into
Draft
feat(input-mapping): AJDA-2714 read description from table definition#533odinuv wants to merge 1 commit into
odinuv wants to merge 1 commit into
Conversation
Member
Author
|
@kudj Chystaná změna input manifestu na komponentě - kvůli přidání description, současně přidává i schema v co nejpodobnějším tvaru jako je na output mappingu. |
zajca
approved these changes
Jun 25, 2026
zajca
left a comment
Member
There was a problem hiding this comment.
Přijde mě to cajk nenapadá mě kde by to mohlo zhučat, necháme sa překvapit.
|
LGTM ദ്ദി(•ᴗ•) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
https://linear.app/keboola/issue/AJDA-2714/input-mapping-read-description-primarily-from-table-definition
Description
Input Mapping now exposes the table/column
descriptionfrom the native first-class definition field in the table manifest, and adds a new first-classschemanode mirroring the output-mapping schema shape.ManifestCreator::writeTableManifestadds two native-sourced fields (purely additive — the legacycolumns/column_metadata/metadatastructures are left untouched):description(top-level): taken fromdefinition.description; omitted when absent/empty.schema: one entry per selected column withname,data_type(base+ the table's actual backend type, includinglength/defaultwhen present),nullable,primary_key, and the nativedescription. Emitted for both typed and non-typed tables (non-typed columns simply omitdata_type/nullable); a table with no definition serializes an emptyschema: [].Key decisions:
KBC.descriptionmetadata is left intact and Connection backfills the native description into it, so consumers without native support keep working. This also avoids having to pick a winner among multiple multi-providerKBC.descriptionrecords.schema[].metadata— it would require collapsing multiple metadata records into a single map (lossy/ambiguous). Raw records stay in the untouchedcolumn_metadata.data_typereflects the table's actual backend only (base+ that one backend), matching the real state of the table.Justification
Native
descriptionis now a first-class field on table/column definitions in Storage. See the linked Linear issue.Plans for Customer Communication
None.
Impact Analysis
Additive change to the table manifest only (new
descriptionandschemakeys; every manifest now also carriesschema, empty when there is no definition). No existing manifest fields change, so current consumers are unaffected. Not gated by a feature flag.Deployment Plan
Release a tagged version.
Rollback Plan
Revert this PR.
Post-Release Support Plan
None.