test(output-mapping,query-service-api-client,staging-provider): AJDA-2820 use loginType none for test workspaces#532
Merged
Merged
Conversation
…2820 use loginType none for test workspaces Snowflake no longer allows creating workspace users with the legacy service account type. PR #528 worked around this by requesting a SNOWFLAKE_SERVICE_KEYPAIR login and registering a generated public key. None of these tests connect to the workspace with its own credentials (output-mapping loads server-side via the Storage API, query-service runs SQL through the Query Service broker, and the staging-provider helper is used only by metadata/cleanup tests), so request a workspace with no login instead. This matches the pattern already used by input-mapping and drops the now-unneeded key-pair generation.
ondrajodas
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
https://linear.app/keboola/issue/AJDA-2820/update-job-runner
Description
Trošku jsem poleštil tady to https://github.com/keboola/platform-libraries/pull/528/changes#diff-97d65c973832a3c296970b648078c6c8251b01e8c35ee84af2d611a0bc680aa9R158
#528 reworked the Snowflake test-workspace setup because Snowflake no longer allows creating workspace users with the legacy service-account type (the empty/default
loginType). It worked around this by requesting aSNOWFLAKE_SERVICE_KEYPAIRlogin and registering a generated public key.That heavier approach isn't needed in these three test setups — none of them ever connects to the workspace with its own credentials:
AbstractTestCase—workspaceCredentialsis never read; data is loaded/cloned server-side via the Storage API by workspace ID.BaseFunctionalTestCase— SQL runs through the Query Service broker (submitQueryJob); the test never opens a workspace connection.WorkspaceProviderFunctionalTest::createWorkspace(default branch) — used only by tests that inspect workspace metadata or exercise cleanup. The explicit key-pair credential-reset test setsloginTypeitself and is unaffected.So all three now create the workspace with
WorkspaceLoginType::NONE(a schema with no Snowflake login), matching the pattern already in use byinput-mapping, and the now-unnecessary key-pair generation is dropped.Justification
Simplifies the merged #528 test setup and aligns it with
input-mapping. See the linked Linear issue.Plans for Customer Communication
None.
Impact Analysis
Test-only changes. The
query-servicecase is the only behavioral assumption worth watching: it relies on the Query Service being able to execute SQL against anone-login workspace via its own privileged connection. Confirmed green by the functional CI suite for these libraries.Deployment Plan
Release a tagged version (libraries).
Rollback Plan
Revert this PR.
Post-Release Support Plan
None.