docs(data-streams): clarify no primary key support#985
Merged
Conversation
State that data streams do not support primary keys (events are appended, no dedup on import) and point users to a downstream deduplication transformation scheduled via a conditional flow, with Kai assistance. Remove the misleading "Edit primary keys" table-settings bullet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@claude review |
keboola-pr-reviewer-bot
left a comment
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 2/5) · profile docs
This PR adds a substantive product-behaviour claim and several in-repo anchor links that cannot be verified from the diff alone.
Concerns:
src/content/docs/storage/data-streams/data-streams.md: New product-behaviour claim (no PK support, append-only) needs product-team confirmation before shipping.src/content/docs/storage/data-streams/data-streams.md: In-repo anchors #primary-key-deduplication and #output-mapping cannot be verified from this diff alone.src/content/docs/storage/data-streams/data-streams.md: In-repo links /flows/ and /kai/ target pages not visible in this diff; existence unverifiable.
Suggested reviewers: keboola/docs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Data Streams documentation to explicitly clarify that Data Streams do not support primary keys (events are appended and not deduplicated at import time), and removes UI wording that previously implied primary key support.
Changes:
- Removed the “Edit primary keys …” bullet from the Data Streams table settings list to avoid implying PK support.
- Added a “No primary key support” note explaining append-only behavior and lack of import-time deduplication.
- Documented a recommended downstream workaround using a deduplication transformation + output-mapping primary key behavior + scheduling via Conditional Flows (with links to relevant docs).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue(s): PROOF-XXX
Clarifies that data streams do not support primary keys — incoming events are appended and no deduplication happens on import. This was misleading before: the Table settings listed an "Edit primary keys" option, implying PK enforcement that does not exist.
Changes:
Docs-only change. Verified locally with
npm run dev(page renders 200, all internal links resolve).