docs: clarify Conditional Flows aggregations are JMESPath, not functions#983
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ondrajodas
left a comment
There was a problem hiding this comment.
Code review — clarify aggregations are JMESPath (AJDA-924)
The core of the change is correct — I verified it against the live keboola.flow schema via get_flow_schema: the function enum is exactly ["COUNT", "DATE"] (no SUM/MIN/MAX/AVG), so aggregations genuinely must be JMESPath in value, and avg is the correct JMESPath spelling. The JSON examples match the schema's functionCondition/taskCondition shapes, the Liquid warning.html include is markdownified so it renders fine, and the #date--time-function anchor resolves correctly (Kramdown drops the &). Build will not break.
Two Important wording/accuracy points and a few Minor style notes inline. Verdict: approve with minor fixes — none are blocking.
…ot functions Document that the Sum/Minimum/Maximum/Average picker aggregations are JMESPath expressions placed in the task value field, not function blocks (the function enum only accepts COUNT and DATE). Add the JMESPath forms, a JSON example for the sum aggregation, and note the result.* (picker tree) vs job.result.* (generated value) path prefix difference. Re-authored onto the Astro/Starlight structure using a :::caution aside. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b4c9f6e to
b9b0d57
Compare
Note for reviewers — branch re-authored onto the Astro/Starlight migrationWhile addressing the review feedback I found that I reset the branch to current
Verified with a local Astro production build ( |
ondrajodas
left a comment
There was a problem hiding this comment.
Approving — all earlier review points are addressed.
- #1 picker codegen claim softened to "can be expressed as" ✔
- #2 added the
result.*(picker tree) vsjob.result.*(generated value) prefix note ✔ - #3 native Markdown list items instead of
•/<br>✔ - #4 emphasis tightened ✔
- #5 "the only functions exposed via the
functionblock" ✔
Core claim stays verified against the live keboola.flow schema (function enum = COUNT/DATE only; aggregations are JMESPath in value). Clean re-author onto the Astro/Starlight :::caution aside. LGTM.
|
Ja nevim k cemu tady vlastne jsme :D |
Jira issue(s): PROOF-XXX
The "one-click aggregations" framing in the Conditional Flows docs implied Sum / Minimum / Maximum / Average are dedicated function constructs. They are not — the
functionenum only acceptsCOUNTandDATE. Each aggregation is generated by the UI picker as a JMESPath expression in the taskvaluefield. Anyone authoring a flow via the API or as a template needs to know the JMESPath equivalents.Changes:
sum(...), Minimum →min(...), Maximum →max(...), Average →avg(...).Sum of importedRowsCountis shown as a JMESPath aggregation in the taskvalue(atype: tasksource), not afunctionblock.COUNTexample to make clear thatCOUNTandDATEare the only true functions (using afunctionblock withoperands), distinct from the JMESPath aggregations.Note: not built locally — Docker daemon was unavailable. Change is plain Markdown plus the existing
warning.htmlinclude; the branch CI build will confirm it compiles.