fix: transformations docs — broken anchors, typos, migration leftovers (PRDCT-354)#981
fix: transformations docs — broken anchors, typos, migration leftovers (PRDCT-354)#981Iamfle4ka wants to merge 1 commit into
Conversation
…leftovers
PRDCT-354
- Fix typo 'suport' → 'support' in snowflake, python, R pages
- Fix broken anchor #snowflake-loading-type → #loading-type-snowflake-and-bigquery
- Fix broken link /transformations/workspace → /workspace/
- Convert 6 absolute help.keboola.com URLs to root-relative paths
- Remove 41 Jekyll {: width="..." } attributes from dbt pages
- Fix 4 wrong code fences (java → bash) in dbt/cli/cli.md
- Remove Confluence class leftover in dbt/index.md
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
keboola-pr-reviewer-bot
left a comment
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 2/5) · profile docs
The PR needs a quick human confirmation on two in-repo link targets that cannot be verified from this diff alone.
Concerns:
src/content/docs/transformations/snowflake-plain/index.md: New anchor #loading-type-snowflake-and-bigquery in /transformations/mappings/ cannot be verified from this diff.src/content/docs/transformations/r-plain/index.md: Replacement link /workspace/ target page existence cannot be verified from this diff.
Suggested reviewers: keboola/docs
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| Before running the dbt transformation, you can configure additional parameters (such as the dbt Core version, backend size, and number of threads), run debug command, or view generated project documentation. | ||
|
|
||
| {: width="50%" } | ||
|  |
There was a problem hiding this comment.
🚩 Removal of {: width="50%"} may change intended image sizing
Two images in dbt/transformation/transformation.md used {: width="50%" } (lines 65 and 110), while most others used {: width="100%" }. The kramdown syntax didn't work in Astro anyway, so removing it is correct. However, these two images were intentionally sized at 50% in the original Jekyll site, suggesting they may appear oversized at their natural dimensions. If the images need constraining, Astro/Starlight's built-in <img> or a wrapper style in src/styles/custom.css could be used instead.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Valid observation, but the {: width="50%" } was already non-functional in Starlight — it rendered as literal visible text next to the image (not as a resize directive). So removing it doesn't change image display behavior; images were already showing at full/natural width.
If these images genuinely need constraining to 50%, that would require a Starlight-native approach (e.g., wrapping in a <div style="max-width:50%"> or a CSS class in custom.css). That's a separate content decision (needs_human=yes in my audit) — flagged for a future pass.
…ck 0/A/B) Now that the Block 0 classification is accessible, aligned #987 with it: - Schema: add `tutorial` to the type enum. - Types per Block 0: cli, r-plain array-splitter/binary/plots, duckdb/ snowflake-migration -> tutorial; troubleshooting -> how-to; flows -> explanation. - Resolved TODO flags verified by Block B (vs component code): snowflake query_timeout=7200 + ABORT_TRANSFORMATION + copy/clone; bigquery Query timeout default 0 + ABORT_TRANSFORMATION; duckdb threads/max_memory_mb/dtypes_infer/ syntax_check/duckdb_version + supported versions {1.5.2,1.4.4} + sync actions; oracle optional db.schema. Kept only platform-level unverifiable flags. - Fixed broken anchors (Block A): #phases/#dependencies (index) and #new-transformations (code-patterns, mappings) — overlaps Devin PR #981. - Updated revamp/PRDCT-376-human-review.md (Resolved section + reconciliation note). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2 participants
Jira issue(s): PRDCT-354
Changes:
#snowflake-loading-type→#loading-type-snowflake-and-bigqueryin snowflake-plain and variables pages/transformations/workspace→/workspace/in r-plain pagehelp.keboola.comURLs to root-relative paths in code-patterns page{: width="..." }attributes from all dbt sub-pages (rendered as literal text in Starlight)java→bash) in dbt/cli pageclass="confluenceTd"Confluence migration leftover from dbt/index pageAll changes are unambiguous mechanical fixes (broken links, typos, migration artifacts). No content restructuring, no field name changes, no needs_human items included.
Full accuracy audit log posted as comment on PRDCT-354.
Link to Devin session: https://app.devin.ai/sessions/c1273d2b614a4fb0b8bede24e12430df
Requested by: @Iamfle4ka