docs(global-search): document re-architecture improvements#977
Merged
romanbracinik merged 4 commits intoJun 23, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Update the Global Search page for the re-architecture work: - search/confidentiality framing now covers table column names (DMD-1601) - Table entity type is findable by its column names - "Matched column" hint in results, with screenshot (DMD-1648) - new "Matching" section: name matching, exact ID (DMD-1643), opt-in regex mode via the search-bar toggle (DMD-1600), with screenshot DMD-1641
romanbracinik
force-pushed
the
romanbracinik-dmd-1641-global-search-update-helpkeboolacom
branch
from
4439834 to
9b2c79a
Compare
keboola-pr-reviewer-bot
left a comment
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 2/5) · profile docs
Placeholder alt text on both new images triggers a flag: from the asset-hygiene skill, which the policy says drops any verdict to needs_human.
Concerns:
src/content/docs/management/global-search/index.md: Alt text 'Screenshot - Matched column' uses placeholder word 'Screenshot'; describe what the UI shows instead.src/content/docs/management/global-search/index.md: Alt text 'Screenshot - Regex mode' uses placeholder word 'Screenshot'; use a descriptive caption.src/content/docs/management/global-search/index.md: New product-behaviour claims (column indexing, exact-ID lookup, Regex mode) cannot be verified from the diff alone.
Suggested reviewers: keboola/docs
Address pr-reviewer-bot: replace placeholder 'Screenshot - ...' alt text on the matched-column and regex images with descriptive captions. DMD-1641
Contributor
Author
|
Addressed the pr-reviewer-bot feedback:
|
keboola-pr-reviewer-bot
left a comment
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 2/5) · profile docs
This PR introduces multiple substantive product-behaviour claims that cannot be verified from the diff alone.
Concerns:
src/content/docs/management/global-search/index.md: New Matching section asserts column-vs-name relevance ranking — unverifiable product-behaviour claim.src/content/docs/management/global-search/index.md: Exact ID matching and Regex mode behaviour are new product-behaviour claims needing author/product confirmation.public/management/global-search/global-search-matched-column.png: Screenshots from local dev build — human should confirm they reflect current production UI state.
Suggested reviewers: keboola/docs
vojtabiberle
approved these changes
Jun 22, 2026
Use monthlyReport instead of monthly_report in the regex whole-name example to avoid implying the underscore is a word separator. DMD-1641
vojtabiberle
approved these changes
Jun 23, 2026
romanbracinik
deleted the
romanbracinik-dmd-1641-global-search-update-helpkeboolacom
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue: DMD-1641 (Global Search re-architecture milestone)
Updates the Global Search page to reflect the user-facing improvements from the Global Search re-architecture.
Changes:
Tableentity type noted as findable by its column names, not just the table name.Screenshots captured against a local
keboola/uibuild withglobal-search-backendenabled. Verified withnpm run build(clean) andnode scripts/audit-phase2.mjs(MISSING IMAGES: 0).Draft — opened for review. Proofreading: create a PROOF issue if needed.