docs(communication): fix inaccurate output columns, broken links, and typos#973
Draft
Iamfle4ka wants to merge 1 commit into
Draft
docs(communication): fix inaccurate output columns, broken links, and typos#973Iamfle4ka wants to merge 1 commit into
Iamfle4ka wants to merge 1 commit into
Conversation
… typos Audited communication extractor docs against source code. Fixes: - Add 3 missing output columns (subject, body_html, attachment_names) to email-imap and ms-outlook (matches component-email-content/src/component.py) - Fix broken query-syntax link in ms-outlook (relative → absolute path to email-imap/query-syntax/) - Fix copy-paste error in gmail: 'Google Analytics' → 'Gmail Messages' - Fix table naming in email-attachments: data1–dataN → data, data1, data2 (matches RunAction.php counter logic) - Add missing IMAP connector to communication/index.md listing - Fix trailing slash on google-calendar link - Add missing table header separators in intercom (22 tables) - Fix typos: specificly, entere, msut, matchess, XSLX Fixes PRDCT-349 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue(s): PRDCT-349
Changes:
Unambiguous doc fixes found during code-vs-docs accuracy audit of
components/extractors/communication/against source repos (keboola/component-email-content,keboola/gmail-extractor,keboola/ex-email-attachments).Code-accuracy fixes (verified against source):
subject,body_html,attachment_names) — code produces 13 cols, docs only listed 10. Evidence:component-email-content/src/component.py:13-27RESULT_COLUMNSquery-syntaxresolved to non-existentms-outlook/query-syntax; fixed to absolute/components/extractors/communication/email-imap/query-syntax/(matches code's own link inconfigRowSchema.json:22)data1–dataN→data,data1,data2… (matchesRunAction.php:180-184counter logic)Structural fixes:
communication/index.mdlisting| --- | --- |table header separators inintercom/index.md(tables rendered as plain text without them)Typos:
specificly→specifically,entere→enter,msut→must(×2),matchess→matches,XSLX→XLSX(×2)NOT included (need human decision):
.+\\.csvin schema vs empty in code)text/*)See PRDCT-349 comment for full audit with code evidence table."
Link to Devin session: https://app.devin.ai/sessions/d709d381ecb94f0a80770c4a3db48337
Requested by: @Iamfle4ka