docs: fix ERP extractor docs accuracy issues (PRDCT-351)#972
Draft
Iamfle4ka wants to merge 1 commit into
Draft
Conversation
- Fix K2 SSH field names to match configSchema UI titles (Remote Address → K2 API Source Address, Remote Port → K2 API Port) - Add missing #private_key_password field to K2 SSH docs - Fix broken K2 documentation link (k2gaia/02 → k2gaia/12) - Convert 3 absolute help.keboola.com links to root-relative - Fix Source Url → Source URL capitalization - Align ERP index title with siblings (ERP → ERP Data Source Connectors) - Add missing redirect_from to ERP index Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue(s): PRDCT-351
Changes:
Code-accuracy fixes (verified against
keboola/component-k2configSchema + source):configSchema.json:#private_key_passwordfield to K2 SSH section (configSchema.json:63-68, used in ssh_utils.py:16-17)k2gaia/02/en/10023272.htm#o57577→ 404; updated to workingk2gaia/12/en/10023272.htmsource_urldescription to match schema: "root address of API" → "address that is used to query the K2 API" (configSchema.json:94)Doc hygiene:
help.keboola.comlinks to root-relative (K2 line 30, NetSuite lines 21, 30)redirect_from: - /extractors/erp/Items requiring human decision (not included in this PR — documented in PRDCT-351 comment):
source_urlconditional visibility (only shown when SSH disabled)service_nameis a URL path segmentLink to Devin session: https://app.devin.ai/sessions/10f42a29dc5a4189bba856e0cefe71a3
Requested by: @Iamfle4ka