docs: Documentation improvement and enforcing#94
Open
kate-shine wants to merge 1 commit intokdy1:masterfrom
Open
docs: Documentation improvement and enforcing#94kate-shine wants to merge 1 commit intokdy1:masterfrom
kate-shine wants to merge 1 commit intokdy1:masterfrom
Conversation
Owner
|
Why did you close this? I think it's a good change :( |
Author
|
Yes, but I found few more places for improvement and wanted to address those first :) |
Author
|
But I can PR those later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there :)
Rweb looks like a really nice framework, and we decided to switch to it from actix for our future projects.
Sadly, it was lacking few documentation strings, which made rweb projects unbuildable in our strict pipeline.
I added those, if you feel like the documentation of some of them is worded badly or should be improved in any way, please let me know :)