sync by kazewong · Pull Request #241 · kazewong/jim

kazewong · 2025-07-24T14:21:42Z

No description provided.

Dagster development

Formatting

Add placeholder unit test for likelihood module

- Reformat long function calls and asset specs for clarity - Use consistent string quoting and indentation - Move assert error messages to multi-line format for readability - Add properties to SingleEventLikelihood for duration and detector names - Refactor likelihood classes for modularity and clarity

Add abstract _likelihood method to SingleEventLikelihood and refactor subclasses to implement core likelihood logic in _likelihood. Move parameter updates and fixed values to evaluate methods for clarity.

Expand unit tests for likelihood classes and add fixtures

…parameters

Fix HeterodynedTransientLikelihoodFD initialization

…-in-single_eventlikelihoodpy 208 replacing keyword arguments in single event likelihood

Jim dev

coderabbitai · 2025-07-24T14:21:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kazewong and others added 28 commits July 9, 2025 10:51

Update dagster interface

7a2ee77

Ruff format

a0a4b88

Merge branch 'jim-dev' into dagster_development

5de8fdb

Merge pull request #234 from kazewong/dagster_development

6b05f77

Dagster development

update RealDataCatalog asset

dfc8122

Merge pull request #235 from kazewong/dagster_development

347442b

Dagster development

Formatting

7c174f5

Merge pull request #236 from kazewong/formatting

71afb16

Formatting

update inner product

5aaab04

Clean up formatting and remove unused import

b08e14b

Add placeholder unit test for likelihood module

Remove unused likelihood functions and refactor time marginalization

95d07ad

Add docstrings to TimeMarginalizedLikelihoodFD class and methods

e5153de

Update likelihood.py

92b7964

Add docstrings to BaseTransientLikelihoodFD class and methods

918fe9e

Add unit tests for BaseTransientLikelihoodFD class

ab782ca

Initiali refactoring of the likelihood class

e9b03c8

Update workbench.py

5eb4ffd

Refactor likelihood evaluation methods to use _likelihood

7f2bfe9

Add abstract _likelihood method to SingleEventLikelihood and refactor subclasses to implement core likelihood logic in _likelihood. Move parameter updates and fixed values to evaluate methods for clarity.

update heterodyne likelihood

85a3c15

ruff formatting

e38b8e7

update run interface

d69c0d2

Add evaluate method to HeterodynedPhaseMarginalizedLikelihoodFD

e6ae3d6

Expand unit tests for likelihood classes and add fixtures

Fix HeterodynedTransientLikelihoodFD initialization to include fixed_…

cbd7d82

…parameters

Merge pull request #238 from kazewong/bugfix

d9cae2a

Fix HeterodynedTransientLikelihoodFD initialization

Refactor likelihood phase difference calculation and clean up code

ecd0a92

Merge pull request #237 from kazewong/208-replacing-keyword-arguments…

2636d96

…-in-single_eventlikelihoodpy 208 replacing keyword arguments in single event likelihood

Merge pull request #240 from kazewong/jim-dev

41005eb

Jim dev

kazewong merged commit 63684c1 into dagster_development Jul 24, 2025
5 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sync#241

sync#241
kazewong merged 28 commits into
dagster_developmentfrom
main

kazewong commented Jul 24, 2025

Uh oh!

coderabbitai Bot commented Jul 24, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kazewong commented Jul 24, 2025

Uh oh!

coderabbitai Bot commented Jul 24, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)