add support for react components in circle displayText#5
Open
turbio wants to merge 4 commits intokauffecup:masterfrom
Open
add support for react components in circle displayText#5turbio wants to merge 4 commits intokauffecup:masterfrom
turbio wants to merge 4 commits intokauffecup:masterfrom
Conversation
kauffecup
requested changes
Sep 23, 2016
Owner
kauffecup
left a comment
There was a problem hiding this comment.
also would you be able to update the readme and provide an example (perhaps even w/ a screenshot)?
once you do these two things i'll up the version number and re-publish it to npm
| }) | ||
| .text(d => d.displayText || d._id) | ||
| .each(function(d){ | ||
| if (typeof d.displayText === 'object') { |
Owner
There was a problem hiding this comment.
let's instead add a different property (instead of mooching off of displayText). maybe something like innerComponent or just component. that'd each this if statement to something like:
if (!!d.innerComponent) {
ReactDOM.render(d.innerComponent);
} else {
...
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is completely compatible with the existing behavior. The only difference is when the
displayTextof a circle is an object, it will use react to mount that object. Otherwise it will behave as before and set the circles text todisplayTextord._id.