refactor brightstaff#736
Merged
adilhafeez merged 16 commits intomainfrom Mar 20, 2026
Merged
Conversation
…r errors - Restore llm.model, llm.tools, llm.user_message_preview, llm.temperature span field recordings that were lost during refactor - Replace agents.as_ref().unwrap() and agent_map.get().unwrap() in orchestrator with proper error returns - Replace from_endpoint().unwrap() with ok_or_else returning 400 - Replace to_bytes().unwrap() with match returning 500 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ining unwraps - Pass Arc<AppState> directly to llm_chat and agent_chat instead of destructuring into individual parameters - Add shared reqwest::Client to AppState for connection pooling on upstream LLM requests - Fix unwrap panics in pipeline.rs: get_new_session_id now returns Result, invoke_agent to_bytes properly handled - Fix unwrap panics in orchestrator.rs: strip_prefix and pop - Fix unwrap panics in response.rs: SSE parsing no longer panics - Fix unwrap panics in router services: serialization errors propagated - Convert old-style string-format debug log in state/mod.rs to structured tracing fields Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
061aa74 to
66e55e1
Compare
…taff Made-with: Cursor # Conflicts: # crates/brightstaff/src/main.rs # crates/brightstaff/src/router/plano_orchestrator.rs
…taff Made-with: Cursor # Conflicts: # crates/brightstaff/src/handlers/agents/orchestrator.rs # crates/brightstaff/src/handlers/agents/pipeline.rs # crates/brightstaff/src/handlers/llm.rs # crates/brightstaff/src/main.rs
- Replace unreachable!() with proper error return in orchestrator agent chain - Remove incorrect #[allow(dead_code)] on routing_provider_name - Change SerError alias to _ (trait import for method resolution only) - Remove dead commented-out code in pipeline.rs - Replace unwrap()s with expect/if-let in LLM handler filter paths - Make find_listener synchronous (no await needed) - Unify message truncation logic via streaming::truncate_message Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppStatestruct; rewritemain.rswith focused helpers and?error propagationtokio::select!(ctrl-c handling)handlers/intoagents/andllm/also restructured tracing