Skip to content

Flush pending pseudo-encodings in writeLosslessRefresh under video mode #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaberudy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Flush pending pseudo-encodings in writeLosslessRefresh under video mode #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion common/rfb/EncodeManager.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,21 @@ void EncodeManager::writeLosslessRefresh(const Region& req, const ScreenSet &la
const RenderedCursor* renderedCursor,
size_t maxUpdateSize)
{
if (videoDetected || video_mode_available)
if (videoDetected || video_mode_available) {
// In video mode there's no lossless refresh to send, but pending
// pseudo-encodings (cursor shape, LED state, etc.) must still be
// flushed — otherwise the cursor shape lags whenever the desktop
// is idle (e.g. user hovering a window edge to resize). Without
// this, writeFramebufferUpdate() reaches us via writeDataUpdate's
// "ui.is_empty() but needFakeUpdate()" branch and we early-return,
// never emitting the FBU that would carry the pseudo-rects.
if (conn->writer()->needFakeUpdate()) {
int nRects = conn->cp.supportsLastRect ? 0xFFFF : 0;
conn->writer()->writeFramebufferUpdateStart(nRects);
conn->writer()->writeFramebufferUpdateEnd();
}
return;
}

doUpdate(false, getLosslessRefresh(req, maxUpdateSize),
Region(), Point(), std::vector<CopyPassRect>(), layout, pb, renderedCursor);
Expand Down