Skip to content

Potential Vulnerability in Cloned Code #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pr-hung wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Potential Vulnerability in Cloned Code #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/encperf.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ class DummyOutStream : public rdr::OutStream {
public:
DummyOutStream();

virtual int length();
virtual size_t length();
virtual void flush();

private:
virtual int overrun(int itemSize, int nItems);
virtual size_t overrun(size_t itemSize, size_t nItems);

int offset;
rdr::U8 buf[131072];
Expand Down Expand Up @@ -141,7 +141,7 @@ DummyOutStream::DummyOutStream()
end = buf + sizeof(buf);
}

int DummyOutStream::length()
size_t DummyOutStream::length()
{
flush();
return offset;
Expand All @@ -153,10 +153,10 @@ void DummyOutStream::flush()
ptr = buf;
}

int DummyOutStream::overrun(int itemSize, int nItems)
size_t DummyOutStream::overrun(size_t itemSize, size_t nItems)
{
flush();
if (itemSize * nItems > end - ptr)
if (itemSize * nItems > (size_t)(end - ptr))
nItems = (end - ptr) / itemSize;
return nItems;
}
Expand Down