merge staging into main#50
Merged
Merged
Conversation
…trollers, service, and aggregation logic; add conversation interfaces and update schemas
…e to utilize it; enhance conversation interfaces with participant preview details
…d message service, and update providers and exports
… conversations, add detailed Swagger documentation, and improve error handling
…mRiderService to automatically create conversations for new custom riders
…tails and update conversation interfaces accordingly
…essage retrieval and conversation management, and enhance interfaces for message handling
… messages, including creation, retrieval, deletion, and read status management; enhance Swagger documentation for API endpoints and improve error handling
…p, update message controller to use new DTOs for conversation parameters, and enhance conversation service verification logic
… documentation by replacing inline definitions with dedicated decorators, enhancing readability and maintainability; implement new decorators for API operations to improve code organization
…pipelines for retrieving unread messages and their counts in the message service, enhancing the functionality for managing direct messages
…message status management, and update pipelines to exclude deleted messages, improving the overall functionality of direct messaging
…ls into message retrieval, update pipelines to include participant information, and refactor message service for improved data handling and response structure
…icipant details for enhanced message retrieval
…ion by consolidating fields from identity and preferences, improving clarity and efficiency in offer retrieval
…projection and ensure avatarUrl is consistently used, improving data clarity in message retrieval
…y replacing displayName with firstName, lastName, and fullName fields, enhancing clarity in user conversation details
… conversationId field for improved offer context and data retrieval
…lidation rules, and refactor SponsorsController and SponsorsService to utilize the new structure, enhancing data integrity and clarity in sponsor updates
Feature/messagerie
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges staging into main, adding a comprehensive direct messaging system and implementing several bug fixes and improvements across the codebase.
- Introduces a complete direct messaging feature with conversations and messages
- Updates sponsors service to fix parameter type and enhance update functionality
- Upgrades shared types dependency to include new conversation-related types
Reviewed Changes
Copilot reviewed 37 out of 39 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/features/sponsors/services/sponsors.service.ts | Fixes parameter type and enhances sponsor update functionality |
| src/features/sponsors/interfaces/update-sponsor.dto.ts | Adds new DTO for sponsor updates with validation |
| src/features/sponsors/controllers/sponsors.controller.ts | Updates to use new sponsor DTO and formatting improvements |
| src/features/offers/services/custom-rider.service.ts | Adds automatic conversation creation on application |
| src/features/offers/pipelines/*.ts | Pipeline optimizations and enum usage improvements |
| src/features/offers/offers.module.ts | Adds DirectMessagesModule import |
| src/features/direct-messages/* | Complete new direct messaging system implementation |
| src/features/features.module.ts | Registers new direct messages module and routes |
| src/common/constants/mongoDbConnections.ts | Adds conversation and message collection constants |
| package.json | Updates shared types dependency version |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| id, | ||
| { | ||
| ...updateSponsorDto, | ||
| logo: newSponsor.avatarUrl, |
There was a problem hiding this comment.
The code sets logo: newSponsor.avatarUrl but earlier on line 86 it sets logo: updateSponsorDto.logo. This creates a conflict where the DTO's logo value is overwritten by avatarUrl, which may not be the intended behavior.
Suggested change
| logo: newSponsor.avatarUrl, |
Comment on lines
+70
to
+72
| const conversationId = new (mongoose as any).Types.ObjectId( | ||
| body.conversationId, | ||
| ); |
There was a problem hiding this comment.
Using 'as any' type assertion with mongoose.Types.ObjectId is unsafe. Import ObjectId directly from mongoose or use proper typing to avoid runtime errors.
Suggested change
| const conversationId = new (mongoose as any).Types.ObjectId( | |
| body.conversationId, | |
| ); | |
| const conversationId = new ObjectId(body.conversationId); |
| }; | ||
|
|
||
| const targetParticipant = { | ||
| userId: new (Types as any).ObjectId(body.targetUserId), |
There was a problem hiding this comment.
Using 'as any' type assertion with Types.ObjectId is unsafe. Import ObjectId directly or use proper typing to avoid potential runtime errors.
Suggested change
| userId: new (Types as any).ObjectId(body.targetUserId), | |
| userId: new ObjectId(body.targetUserId), |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Lucas-Huerta
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.