Merge staging to main#44
Merged
Merged
Conversation
🐛 fix logger on avatar update
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request merges staging to main and includes refactoring improvements to the riders service and controller. The changes focus on code quality improvements through better logging practices and constant extraction.
- Extracted a magic string constant for avatar reset functionality
- Enhanced logging structure by logging specific object properties instead of entire objects
- Improved log output clarity in the riders controller
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/features/riders/services/riders.service.ts | Added constant for avatar reset string and improved avatar file logging structure |
| src/features/riders/controllers/riders.controller.ts | Changed user logging to only log the slug property instead of entire user object |
🔥 remove .slug from logger
ImJustLucas
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.