Skip to content

Conversation

@kaosdg
Copy link
Owner

@kaosdg kaosdg commented Feb 27, 2019

Type of change(s)

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Hotfix / Breakfix (fix or feature that would cause existing functionality to change)
  • Refactoring (changes in code organization without major change in functionality)
  • Documentation addition / update (changes in stored documentation that does not affect functionality)
  • CI/CD change (changes to any versioned CI related configuration / tools)

Before You Begin

  • Builds clean without any errors?
  • Jira ticket URL has been added to the title above (e.g. CNBCMAPP-420)
  • I have added / updated tests to cover my changes.
  • Have all new and existing tests passed?
  • I have updated the documentation accordingly.
  • Has this been signed off by Product or Design?
If any of the above are not checked please explain why:

Description of Your Changes

How Has This Been Tested?

Provide the steps to test this

Device / Form Factor Checklist

This PR has been tested with the following devices:

  • Not Applicable
  • iPhone
    • Large (Plus, Max)
    • X (X, Xr, Xs)
    • Standard
  • iPad
    • Large
    • Regular
    • Medium
  • Landscape
  • Portrait

Screenshots (if appropriate):

Dependencies

Provide details on other PRs that are dependent on this / this PR is dependent on:

Documentation

If you created / updated documentation, necessary documentation & links (if applicable):

Notes

@KaosDGBot
Copy link
Collaborator

3 Errors
🚫 You did not complete the Type of change(s) checklist
🚫 You did not complete the Before you begin checklist
🚫 Please add the JIRA ticket to the title

Danger Completed with 3 errors

Uh Uh Uh!

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants