Add currency signs to /v1/currencies endpoint#6
Merged
Conversation
Co-authored-by: kamaal111 <37084924+kamaal111@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Expand currencies endpoint with currency signs
Add currency signs to /v1/currencies endpoint
Mar 3, 2026
kamaal111
reviewed
Mar 3, 2026
| if !ok { | ||
| name = symbol | ||
| name := symbol | ||
| sign := "" |
Owner
There was a problem hiding this comment.
@copilot don't juggle with empty values just append in the if ok clause
Contributor
Author
There was a problem hiding this comment.
Done in c3cfc8e — the loop now appends directly inside the if ok clause, removing the intermediate variables.
Co-authored-by: kamaal111 <37084924+kamaal111@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CurrencyInfostruct withNameandSignfields tohandlers/service.goCurrencyNamesmap frommap[string]stringtomap[string]CurrencyInfowith currency signsSignfield toNamedSymbolstructGetAllNamedSymbols()to include sign in response (append directly in if-ok clause)handlers/named_symbols_test.goto verify sign fieldTestGetCurrenciesEndpointto verify sign fieldREADME.mdwith updated/v1/currenciesexample response showing sign fieldOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.