Skip to content

Cherrypick PR #1716 from upstream#141

Merged
EnriqueL8 merged 4 commits into
release-v1.3.3from
djc-1.3.3
Apr 22, 2026
Merged

Cherrypick PR #1716 from upstream#141
EnriqueL8 merged 4 commits into
release-v1.3.3from
djc-1.3.3

Conversation

@davecrighton

Copy link
Copy Markdown

Proposed changes

This PR cherrypicks in changes from hyperledger-firefly#1716 into the Kaleido fork of firefly-core.

From that PR:

This change tests the error string before making an update to the operations table checking that it is a valid UTF-8 string and does not contain null bytes. The second check is required because UTF-8 considers a single null byte to be a valid string but Postgres does not.

Fixes hyperledger-firefly#1717


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.

…om reverts

Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
…can decide whether to take different action on nilPtr

Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
@davecrighton davecrighton requested a review from a team as a code owner April 22, 2026 10:30
@davecrighton davecrighton changed the title Djc 1.3.3 Cherrypick PR #1716 from upstream Apr 22, 2026
@EnriqueL8 EnriqueL8 merged commit dc4f33d into release-v1.3.3 Apr 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants