enable declaring custom topics for ffi interface publish and ff publish api create #140
Open
ka1ii wants to merge 2 commits into
Open
enable declaring custom topics for ffi interface publish and ff publish api create #140ka1ii wants to merge 2 commits into
ka1ii wants to merge 2 commits into
Conversation
Signed-off-by: Kaijun Zhang <kaijun1543111@gmail.com>
ka1ii
changed the title
Signed-off-by: Kaijun Zhang <kaijun1543111@gmail.com>
awrichar
reviewed
Apr 6, 2026
|
|
||
| var filtered []string | ||
| for _, t := range customTopics { | ||
| if t != "" { |
There was a problem hiding this comment.
Wonder if this filtering is needed, or if we should just let it go through and fail later (I assume message validation fails if you pass no topics or empty topics?)
Author
There was a problem hiding this comment.
yea but then we would need to add a try catch + this allows us to detect if we need to use the default topic or use the ones declared by the client
awrichar
reviewed
Apr 6, 2026
| }, | ||
| QueryParams: []*ffapi.QueryParam{ | ||
| {Name: "confirm", Description: coremsgs.APIConfirmMsgQueryParam, IsBool: true}, | ||
| {Name: "topics", Description: coremsgs.APICustomTopicsQueryParam, IsArray: true}, |
There was a problem hiding this comment.
Probably need to consider if this should be a query param or body param... I was expecting it to be in the body (like NetworkName)
Author
There was a problem hiding this comment.
I thought of topic as something about the request, but I think you are right here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses this issue: hyperledger-firefly#1725
example of ff define interface and ff create contract api being on the same topic